Skip to content

initial apphosting mcp tool #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
May 22, 2025
Merged

initial apphosting mcp tool #8605

merged 18 commits into from
May 22, 2025

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented May 15, 2025

Description

Adds an initial MCP tool for App Hosting.

This combines the Backend and it's singleton Traffic resource into one so that the LLM can make some inferences about the traffic information!

It also adds a tool so that it can fetch build or service logs!

Scenarios Tested

Sample Commands

@bkendall bkendall requested a review from joehan May 19, 2025 19:03
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I'd defer to @joehan on when the code freeze ends and we are ready to adding more tools~

@github-project-automation github-project-automation bot moved this from Approved [PR] to Changes Requested [PR] in [Cloud] Extensions + Functions May 19, 2025
Copy link
Contributor

@fredzqm fredzqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG since we are exiting code freeze.

@github-project-automation github-project-automation bot moved this from Changes Requested [PR] to Approved [PR] in [Cloud] Extensions + Functions May 22, 2025
@bkendall bkendall changed the title initial apphosting mcp tool initial apphosting mcp tool, plus cloud run logs May 22, 2025
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - but should we enable this tool when you enable app hosting tools too?

@bkendall bkendall changed the title initial apphosting mcp tool, plus cloud run logs initial apphosting mcp tool May 22, 2025
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after cleanup

@bkendall bkendall enabled auto-merge (squash) May 22, 2025 21:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.07%. Comparing base (2263d68) to head (67e3d14).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
src/gcp/run.ts 20.00% 8 Missing ⚠️
src/gcp/apphosting.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8605      +/-   ##
==========================================
+ Coverage   51.04%   51.07%   +0.02%     
==========================================
  Files         431      431              
  Lines       30986    31015      +29     
  Branches     6367     6371       +4     
==========================================
+ Hits        15818    15840      +22     
- Misses      13752    13760       +8     
+ Partials     1416     1415       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bkendall bkendall merged commit f56d79a into master May 22, 2025
48 of 50 checks passed
@bkendall bkendall deleted the bk-mcp-apphosting branch May 22, 2025 21:16
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 22, 2025
TrCaM pushed a commit that referenced this pull request May 26, 2025
* initial apphosting mcp tool

* add fetchServiceLogs function

* add run tool to fetch logs

* add a little more description for location

* cleaning up logic a bit

* add new tools to smoke test

* don't reinvent the cloud run logs wheel

* back out cloud run tool

* creates a new logs helper for app hosting for both build and runtime logs

* lint issues

* some funny business got into my code. undoing it

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants